Fix duplicate inherited discriminators in Java models - #11824
Draft
Xiaofei Cao (XiaofeiCao) wants to merge 3 commits into
Draft
Fix duplicate inherited discriminators in Java models#11824Xiaofei Cao (XiaofeiCao) wants to merge 3 commits into
Xiaofei Cao (XiaofeiCao) wants to merge 3 commits into
Conversation
Merge redundant leaf discriminator declarations with propagated parent discriminators and preserve fixed discriminator fields as final. Fixes microsoft#11802 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54b93dc2-48ce-4250-a6ea-5bd9b9a7ab2b
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54b93dc2-48ce-4250-a6ea-5bd9b9a7ab2b
Keep active discriminators mutable so unknown values can round-trip through fallback deserialization, while fixed ancestor branch discriminators remain final. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54b93dc2-48ce-4250-a6ea-5bd9b9a7ab2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalwithout changing shared serialization behaviorFixes #11802
Testing
http-client-generator-clientcore-test/Generate.ps1regenerationhttp-client-generator-test/Generate.ps1regeneration