Skip to content

optimize getSignatureHelp callback in lsp #8804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

optimize getSignatureHelp callback in lsp #8804

wants to merge 4 commits into from
+155 −39

Conversation

@RodgeFu
Copy link
Contributor

@RodgeFu RodgeFu commented Oct 23, 2025

getSignatureHelp would keep triggering compile when user's typing, so leverage update manager to avoid the frequent triggering.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/compiler@8804

commit: e8736cf

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - internal ✏️

Optimize the getSignatureHelp callback of LSP

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 23, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@RodgeFu RodgeFu changed the title leverage updateManager to avoid frequent compile from getSignatureHelp optimize getSignatureHelp callback in lsp Oct 23, 2025
@RodgeFu RodgeFu added the ide Issues for VS, VSCode, Monaco, etc. label Oct 23, 2025
@RodgeFu RodgeFu marked this pull request as ready for review October 23, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ide Issues for VS, VSCode, Monaco, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RodgeFu @azure-sdk