-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Finalize migration plugins integration and introduce an internal plugin registry #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
… migration option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR finalizes the migration plugins integration by replacing the chooseDataMigrationExtension
command with a new accessDataMigrationServices
command and introduces an internal plugin registry for better client verification and announced provider support.
- Command Migration: Replaces
chooseDataMigrationExtension
withaccessDataMigrationServices
throughout the extension - Enhanced Provider Support: Adds support for announced migration providers with marketplace integration
- Client Registration: Introduces verified client tracking and automatic registration via internal commands
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/services/migrationServices.ts |
Adds client extension registration and announced provider listing functionality |
src/extension.ts |
Adds internal command for client registration and updates API version |
src/documentdb/ClustersExtension.ts |
Updates command registration to use new migration services command |
src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts |
Removes old command implementation |
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts |
Implements new command with marketplace integration and announced providers |
package.json |
Updates command references, adds announced providers config, and renames client verification fields |
l10n/bundle.l10n.json |
Adds localization string for client registration |
api/src/utils/getApi.ts |
Updates client verification logic and adds automatic registration |
api/package.json |
Bumps API version to 0.3.0 |
Files not reviewed (1)
- api/package-lock.json: Language not supported
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts
Outdated
Show resolved
Hide resolved
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…egration-and-introduce-a-plugin-registry
It is ready for the release 🚀. Waiting for a confirmation from the migration team. |
This pull request introduces several updates focused on improving the data migration provider system and refining client extension verification for the VS Code DocumentDB extension. The changes include renaming and restructuring API configuration fields, updating command references, and adding support for announced migration providers. The most significant update is the addition of a new command handler for accessing data migration services, which enhances the user experience for selecting and interacting with migration providers.
Introduces an always visible context menu item for
Data Migration...
.The context menu item activates a QuickPick with a list of supported migration providers (this list can be extended):
Data Migration Provider Improvements
accessDataMigrationServices
insrc/commands/accessDataMigrationServices/accessDataMigrationServices.ts
to present users with a quick pick for installed and announced migration providers, including marketplace integration and authentication handling.package.json
fromchooseDataMigrationExtension
toaccessDataMigrationServices
for all relevant UI actions, ensuring the new handler is used throughout the extension. [1] [2] [3]package.json
under the newx-announcedMigrationProviders
field, allowing the extension to surface marketplace providers to users.API Configuration and Client Verification Updates
package.json
andapi/src/utils/getApi.ts
fromregisteredClients
toverifiedClients
, and updated logic to check for verified clients when authorizing API access. [1] [2] [3]getDocumentDBExtensionApi
by adding an internal command call to register the client extension, with error handling and logging for registration failures.Miscellaneous
0.2.0
to0.3.0
in bothapi/package.json
andapi/package-lock.json
to reflect these significant updates. [1] [2]l10n/bundle.l10n.json
.