Track e2e startup time #1202
Draft
Track e2e startup time #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <[email protected]>
| while(!javaExt.isActive && count < timeout) { | ||
| await delay(1000); | ||
| count += 1000; | ||
| } |
There was a problem hiding this comment.
The condition branch if (javaExt && !javaExt.isActive) should end at L130. Otherwise, the subsequent code won't be executed if the Java extension is already activated.
There was a problem hiding this comment.
I was intended to do this, while not sure if this makes enough sense. What do you think about the follow case:
- In an empty workspace, user triggers some
redhat.javaspecific command. such as
to open a webview. - Then,
redhat.javawill be activated, while pack is not.
So the purpose here is to make sure that two extensions are almost activated at the same time.
MrG9090
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.