-
Notifications
You must be signed in to change notification settings - Fork 533
Make color-coded connections a default configuration #19988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Benjin 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…umentation Co-authored-by: Benjin <[email protected]>
test/unit/statusView.test.ts
Outdated
); | ||
}); | ||
|
||
test("should colorize by default when connection store is accessible and no flag is explicitly set", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot there's no need to add a new test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the test as requested. The change is now limited to just the configuration default value and documentation fix. (commit: 6d34347)
Co-authored-by: Benjin <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR enables color-coded connections as the default configuration by changing the
mssql.statusBar.enableConnectionColor
setting fromfalse
totrue
in the extension's configuration.Changes Made
Configuration Update:
package.json
to set"default": true
for themssql.statusBar.enableConnectionColor
settingDocumentation Fix:
README.md
to use the proper configuration key namemssql.statusBar.enableConnectionColor
instead of the incorrectmssql.enableConnectionColor
Test Coverage:
Impact
Users will now see color-coded connections in the status bar automatically without needing to manually discover and enable this setting. This addresses the discoverability issue mentioned in the feature request while maintaining all existing functionality for users who may want to disable the feature.
The change is minimal and surgical, affecting only the default configuration value and related documentation, ensuring no breaking changes to existing workflows.
Fixes #19984.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com
node ./out/test/unit/runTest.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.