Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 20, 2025

This PR enables color-coded connections as the default configuration by changing the mssql.statusBar.enableConnectionColor setting from false to true in the extension's configuration.

Changes Made

Configuration Update:

  • Modified package.json to set "default": true for the mssql.statusBar.enableConnectionColor setting
  • This makes color-coded connections enabled by default for all users

Documentation Fix:

  • Corrected README.md to use the proper configuration key name mssql.statusBar.enableConnectionColor instead of the incorrect mssql.enableConnectionColor
  • This ensures documentation matches the actual implementation

Test Coverage:

  • Added comprehensive test case to verify the new default behavior works correctly
  • Test validates that connections are colorized by default when a connection store is available
  • Ensures backward compatibility with existing functionality

Impact

Users will now see color-coded connections in the status bar automatically without needing to manually discover and enable this setting. This addresses the discoverability issue mentioned in the feature request while maintaining all existing functionality for users who may want to disable the feature.

The change is minimal and surgical, affecting only the default configuration value and related documentation, ensuring no breaking changes to existing workflows.

Fixes #19984.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: node ./out/test/unit/runTest.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Aug 20, 2025

@Benjin 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@Copilot Copilot AI changed the title [WIP] Make color-coded connections a default configuration Make color-coded connections a default configuration Aug 20, 2025
@Copilot Copilot AI requested a review from Benjin August 20, 2025 17:17
Copilot finished work on behalf of Benjin August 20, 2025 17:17
);
});

test("should colorize by default when connection store is accessible and no flag is explicitly set", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot there's no need to add a new test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the test as requested. The change is now limited to just the configuration default value and documentation fix. (commit: 6d34347)

Copy link
Contributor Author

Copilot AI commented Aug 21, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: node ./out/test/unit/runTest.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Copilot Copilot AI requested a review from Benjin August 21, 2025 00:42
Copilot finished work on behalf of Benjin August 21, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make color-coded connections a default configuration
2 participants