Skip to content

Conversation

@samgusick
Copy link
Contributor

@samgusick samgusick commented Sep 24, 2025

Pull Request Template – vscode-mssql

Description

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

This PR makes it easier to expand or contract one or more selected columns in the query results grid with two simple shortcuts: CTRL + Scroll up (to expand a column/columns) and CTRL + Scroll Down (to contract a column/columns). Full column selection is not required, a single selection in a column and anything in between will work. This also makes expanding a column that trails off the end of the query results WebView much easier to expand.

P.S. my other PR needs review

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@kburtram
Copy link
Member

@croblesm, @caohai - can you take a look at this PR? It seems like a reasonable shortcut to quickly resize columns - not sure if it conflicts with other aspects of the design.

@caohai
Copy link
Member

caohai commented Nov 25, 2025

@aasimkhan30 Can you also take a look and see if this aligns with your planned improvements in the query result area?

@caohai
Copy link
Member

caohai commented Nov 25, 2025

A few thoughts:

  1. VS Code itself has a setting that allows mouse wheel zoom, this feature would conflict with that if editor.mouseWheelZoom is enabled.
    image
  2. For users with a trackpad (mostly laptop users), wheel event will also capture trackpad "scroll" causing confusion. See this comment from VS Code repo "editor.mouseWheelZoom": true - should be on by default vscode#97137 (comment)

@croblesm Do we want to allow a customizable key binding for column resizing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants