-
Notifications
You must be signed in to change notification settings - Fork 551
Changes to allow reporting success with an action on sqlTasksService #20651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20651 +/- ##
==========================================
+ Coverage 62.65% 62.94% +0.29%
==========================================
Files 209 209
Lines 19350 19390 +40
Branches 2461 2464 +3
==========================================
+ Hits 12124 12206 +82
+ Misses 7146 7102 -44
- Partials 80 82 +2
🚀 New features to boost your workflow:
|
| /** | ||
| * Helper method to register task completion handlers for DacPac operations | ||
| */ | ||
| private registerTaskCompletionHandlers(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this method is only used for DACPAC-related completion handlers, could we rename it to something more specific like registerDacpacTaskCompletionHandlers?
Also, I’m wondering if we should start moving some of this logic out of mainController into feature-specific modules (e.g. a DACPAC-specific file) and just import/register them here. This file is starting to get quite large, and splitting by feature area might make it easier to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this registration should be done by the dacpacDialogWebviewController when it launches the first time. It wouldn't need to unregister upon webview disposal because that would revert to the less helpful task completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe the dacfxService constructor would be even better.
…rations so it could be match and use to pull the right handler.
Description
This PR refactors the task completion notification system to eliminate duplicate notifications for DacFx operations (Export BACPAC, Extract DACPAC, Import BACPAC, Deploy DACPAC) and provides a generic, configurable solution for custom task completion handlers, as reported in this bug.
Problem
Previously, DacFx operations showed two notifications:
A custom notification with action button from dacpacDialogWebviewController
A generic completion notification from sqlTasksService
Solution
Centralized all task completion notification logic in sqlTasksService with a configurable handler registration system.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines