Skip to content

Conversation

@aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

  1. Wraps request handlers and reducers for web view in telemetry and log statements.
  2. Wraps "CancelQuery" and "GetRows" in logs and telemetry.
  3. Not disposing query runners when the panel is still open

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5263 KB 5263 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5627 KB 5627 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.64935% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.34%. Comparing base (333286c) to head (7633149).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/queryRunner.ts 29.16% 17 Missing ⚠️
...ssql/src/controllers/reactWebviewBaseController.ts 51.72% 14 Missing ⚠️
extensions/mssql/src/queryResult/utils.ts 58.33% 5 Missing ⚠️
...sions/mssql/src/models/sqlOutputContentProvider.ts 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.64%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20687      +/-   ##
==========================================
- Coverage   63.36%   63.34%   -0.03%     
==========================================
  Files         210      210              
  Lines       19374    19427      +53     
  Branches     2458     2464       +6     
==========================================
+ Hits        12277    12306      +29     
- Misses       7016     7041      +25     
+ Partials       81       80       -1     
Files with missing lines Coverage Δ
extensions/mssql/src/sharedInterfaces/telemetry.ts 100.00% <100.00%> (ø)
extensions/mssql/src/telemetry/telemetry.ts 93.18% <100.00%> (+0.49%) ⬆️
...sions/mssql/src/models/sqlOutputContentProvider.ts 38.90% <33.33%> (-0.05%) ⬇️
extensions/mssql/src/queryResult/utils.ts 56.52% <58.33%> (+0.11%) ⬆️
...ssql/src/controllers/reactWebviewBaseController.ts 71.62% <51.72%> (-1.85%) ⬇️
extensions/mssql/src/controllers/queryRunner.ts 50.00% <29.16%> (-0.59%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasimkhan30 aasimkhan30 changed the title Adding telemetry to query apis calls and fixing disposal. Adding telemetry to query apis calls and fixing query disposal. Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants