Skip to content

Conversation

eugengi
Copy link

@eugengi eugengi commented Jul 22, 2024

Description

This branch introduces a simple patch to the go version spec in the go.mod file. This PR's primary goal is to sync the go version spec in the go.mod file with the go version for the precompiled image for the Dev Container (maintained by Microsoft). From observing the repo's commit history, the template was initialized using go 1.14 and requires manual user intervention to sync this version with the precompiled image releases from Microsoft.

Decisions

This section outlines notable considerations for developers/maintainers.

This patch requiring manual user intervention can be automated with minimal effort using one of the following tools:

Example of custom pre-commit hook:

-   id: sync-go-version
    name: Sync Go Version
    description: Syncs go version in mod file with version spec in pre-built image.
    entry: sync-go-version  # bash script with logic to execute
    language: script
    files: \.devcontainer/devcontainer\.json$
    types: [text]

Testing

Tests run: N/A

Additional

  • [Decision] Both tools recommended have pros and cons. A GitHub action is more centralized and "automated" but involves a more complex setup. A custom pre-commit hook is easier to set up but introduces a dependency on the local developer environment and package installation and configuration (minimal) of pre-commit.

Bump go version to the latest current minor version v1.22.

[Reason]
Sync this with the `go` version of the precompiled Dev container image.
@eugengi
Copy link
Author

eugengi commented Jul 22, 2024

I'm happy to make a subsequent PR with the team's chosen automation tool choice✅

module github.com/microsoft/vscode-remote-try-go

go 1.19
go 1.22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.22
go 1.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants