Skip to content

Remove MSTest.Assert.Extensions #15178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 17, 2025
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 30, 2025

I personally don't find much value in using these helpers. But up to you @nohwnd to decide

@Youssef1313 Youssef1313 marked this pull request as draft June 30, 2025 11:37
@Youssef1313 Youssef1313 changed the title draft Remove MSTest.Assert.Extensions Jul 1, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review July 1, 2025 02:21
@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/MSTest.Assert.Extensions branch from 4d9705b to 18fee0b Compare July 15, 2025 17:31
@Youssef1313
Copy link
Member Author

@nohwnd Your last commit is going to break non-Windows :)

I think we will want to add the package references back with a condition to be non-Windows only.

@nohwnd nohwnd enabled auto-merge (squash) July 17, 2025 09:54
@nohwnd nohwnd merged commit f97214f into main Jul 17, 2025
7 checks passed
@nohwnd nohwnd deleted the dev/ygerges/MSTest.Assert.Extensions branch July 17, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants