Handle dotnet_root in testhost version aware way #15184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was attempted before but the testnost apphost was too old to undestand the architecture specific dotnet_root: https://github.com/microsoft/vstest/pull/3715/files |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nohwnd
commented
Jul 4, 2025
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Jul 4, 2025
...rosoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/CustomTestHostTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 4, 2025
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 4, 2025
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 4, 2025
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Show resolved
Hide resolved
Youssef1313
approved these changes
Jul 4, 2025
mariam-abdulla
approved these changes
Jul 7, 2025
nohwnd
added a commit
that referenced
this pull request
Aug 11, 2025
* Handle dotnet_root in testhost version aware way (#15184) * Handle dotnet_root in testhost version aware way * Fix unit tests * Fixes * Fixes * Fixes * Apply suggestion from @nohwnd * Apply suggestion from @nohwnd * Revert changes to playground * Only apply architecture when it is the same (#15250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
VSTEST_DOTNET_ROOT_PATHandVSTEST_DOTNET_ROOT_ARCHITECTUREthat will receive the location of dotnet.exe from the dotnet SDK.When we find testhost.exe we will set env variables based on the version of testhost, to make sure that old testhost gets dotnet_root and new one gets dotnet_root_ so they can pick up local installation of dotnet.
Related dotnet/sdk#49436