Fix string inconsistencies in permissions-descriptions.json#1246
Merged
Fix string inconsistencies in permissions-descriptions.json#1246
Conversation
…alidation test Co-authored-by: jasonjoh <8966342+jasonjoh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] String inconsistencies in permissions-descriptions.json
Fix string inconsistencies in permissions-descriptions.json
Aug 29, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes string inconsistencies in the permissions-descriptions.json file by removing trailing spaces and standardizing punctuation across permission display names.
- Removes trailing spaces from both
adminConsentDisplayNameandconsentDisplayNamefields - Standardizes punctuation by removing trailing periods from display names
- Adds comprehensive test coverage to prevent future formatting regressions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
permissions/permissions-descriptions.json |
Cleaned up 79 string inconsistencies by removing trailing spaces and periods from permission display names |
tests/permissions-descriptions.spec.js |
Added new test suite with comprehensive validation for trailing/leading spaces and period consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jasonjoh
approved these changes
Aug 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses string inconsistencies in the
permissions-descriptions.jsonfile between admin and non-admin display names, as reported in the issue.Issues Fixed
The analysis identified 79 string inconsistencies across 582 permissions, including:
"Read all webhook subscriptions "→"Read all webhook subscriptions")"Read and write all users' passkey methods."→"Read and write all users' passkey methods")Changes Made
adminConsentDisplayNameandconsentDisplayNamefieldsExamples of Fixes
Validation
tests/permissions-descriptions.spec.js) that validates all permissions for proper formattingThese changes improve the consistency and professional appearance of permission display names without altering their meaning or functionality.
Fixes #223.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.microsoft.comnode scripts/test-initiator.js(dns block)learn.microsoft.comnode scripts/test-initiator.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.