Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JSON validation workflow by replacing the deprecated orrosenblatt/validate-json-action with dsanders11/json-schema-validate-action and fixes schema syntax issues that the new validator detected.
- Replaced deprecated JSON validation action with actively maintained alternative
- Fixed JSON schema syntax by converting tuple-based item definitions to object-based definitions
- Updated GitHub Actions checkout versions and added workflow dispatch trigger
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/validate.yml |
Replaced deprecated JSON validator action and updated checkout versions |
tests/samples.schema.json |
Fixed schema syntax by converting tuple-based items to object-based and added schema version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old validator
orrosenblatt/validate-json-actionhasn't been updated since 2019 and was using deprecated tech. For example, https://github.com/microsoftgraph/microsoft-graph-devx-content/actions/runs/17332688629:Updating to
dsanders11/json-schema-validate-actiongives the following advantages:strict mode: "items" is 1-tuple, but minItems or maxItems/additionalItems are not specified or different at path "#/properties/SampleQueries/items/properties/headers"