-
Notifications
You must be signed in to change notification settings - Fork 88
fix(transformers) seamless_m4t ut bugs #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Dong1017, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a mixed dtype
error in the seamless_m4t
unit tests by introducing a mechanism to selectively cast input tensors to integer types. This is achieved by adding an inputs_type_idx
parameter to the test cases. While the overall approach is correct, I've found a few issues with the implementation. The lists of indices for type conversion are incorrect for several test cases, which would lead to tensors like labels
and input_ids
being improperly cast to float types. I've provided suggestions to correct these lists. Additionally, the type casting logic for PyTorch tensors is inefficient and can be simplified, for which I've also suggested a refactoring. Addressing these points will make the tests more robust and correct.
What does this PR do?
Fixes
The torch-version
Seamless_m4t
modules will raise "RuntimeError: mixed dtype (CPU): all inputs must share the same datatype", in the case when passing inputs with float datatype.It can be directly avoided by changing
hidden_states = self.layer_norm(hidden_states)
to
hidden_states = self.layer_norm(hidden_states.to(self.layer_norm.weight.dtype))
in
seamless_m4t/modeling_seamless_m4t.py
.But, instead of changing the HF codes, a mask is designed to enforce the type conversion (from float to int) in UTs.
Notes
Refer to #1293
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx