Skip to content

Conversation

Dong1017
Copy link
Contributor

@Dong1017 Dong1017 commented Sep 30, 2025

What does this PR do?

Fixes

The torch-version Seamless_m4t modules will raise "RuntimeError: mixed dtype (CPU): all inputs must share the same datatype", in the case when passing inputs with float datatype.
It can be directly avoided by changing hidden_states = self.layer_norm(hidden_states)
to hidden_states = self.layer_norm(hidden_states.to(self.layer_norm.weight.dtype))
in seamless_m4t/modeling_seamless_m4t.py.
But, instead of changing the HF codes, a mask is designed to enforce the type conversion (from float to int) in UTs.

Notes

Refer to #1293

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@Dong1017 Dong1017 requested a review from vigo999 as a code owner September 30, 2025 10:04
Copy link
Contributor

Summary of Changes

Hello @Dong1017, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a RuntimeError encountered in seamless_m4t unit tests, which occurred due to mixed data types when passing different input types. The solution involves introducing a mechanism to explicitly enforce type conversion for specific input tensors within the test suite, preventing the error without altering the core hf module code. This ensures the robustness of the unit tests by standardizing input data types where necessary.

Highlights

  • Test Parameterization Update: Modified the pytest.mark.parametrize decorator and the test_named_modules function signature to include a new inputs_type_idx parameter.
  • Input Type Conversion Logic: Implemented conditional type conversion for input tensors within test_named_modules, ensuring that specific inputs are cast to long() (for PyTorch) or ms.int64 (for MindSpore) based on the inputs_type_idx list.
  • Test Case Configuration: Updated various test case configurations within get_config to provide the appropriate inputs_type_idx lists, addressing the RuntimeError caused by mixed data types in seamless_m4t unit tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a mixed dtype error in the seamless_m4t unit tests by introducing a mechanism to selectively cast input tensors to integer types. This is achieved by adding an inputs_type_idx parameter to the test cases. While the overall approach is correct, I've found a few issues with the implementation. The lists of indices for type conversion are incorrect for several test cases, which would lead to tensors like labels and input_ids being improperly cast to float types. I've provided suggestions to correct these lists. Additionally, the type casting logic for PyTorch tensors is inefficient and can be simplified, for which I've also suggested a refactoring. Addressing these points will make the tests more robust and correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant