-
Notifications
You must be signed in to change notification settings - Fork 88
feat(transformers): supplement glm4v processor #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @wcrzlh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the multimodal processing capabilities for the GLM-4V model within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the Glm4vProcessor
and Glm4vImageProcessor
to support the GLM-4V model. The changes include adding these new processor classes, registering them with the Auto classes, and updating an example script to use them. Additionally, there are some related refactorings and fixes in other parts of the codebase, such as flash attention integration and processing utilities.
My review has identified a critical issue in the new Glm4vImageProcessor
that would cause a runtime error, and a high-severity issue in Glm4vTextModel
related to state management that could lead to incorrect behavior. Please see the detailed comments for suggestions on how to fix these issues.
What does this PR do?
This pr is proposed to add glm4v processor to avoid torchvision usage during transformers >= 4.53.0.
Fixes # (issue)
✅
LogitsProcessorList
/StoppingCriteriaList
is imported from mindone.transformers rather than transformers to avoid problem of tsf version incompatibility✅ supplement
chat_template.jinja
call in processing_utilsAdds # (feature)
✅ Glm4vImageProcessor/Glm4vProcessor
✅ Update ms2.7.0 performance
Example Usage & Performance
Please refer to usage & performance from Glm4v docs.
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx