-
Notifications
You must be signed in to change notification settings - Fork 88
fix(transformers): fix fast UT errors of Hubert #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @LiTingyu1997, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves recurring unit test failures for the Hubert model by adjusting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a unit test failure for the Hubert model by increasing the precision tolerance for bfloat16
computations. The threshold has been raised from 5e-3
to 5e-2
. While this resolves the test failure, such a significant increase in the tolerance might mask potential precision regressions in the future. I have added a review comment suggesting the addition of an inline comment to document the reason for this high threshold, which will improve code clarity and maintainability.
from tests.transformers_tests.models.modeling_common import floats_numpy, random_attention_mask | ||
|
||
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-3} | ||
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing the bf16
threshold by a factor of 10 to 5e-2
is a significant change that could mask future precision regressions. To maintain test quality, it's important to keep thresholds as tight as possible.
If this large threshold is necessary due to limitations with bfloat16
on CPU, please add an inline comment to explain the reason. This provides valuable context for future developers and justifies the large value.
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-2} | |
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-2} # Increased for bf16 on CPU due to precision issues. |
What does this PR do?
Fixes # (issue)
Enlarged the bf16 threshold of Hubert, torchcpu don't support bf16
Fixes # (issue)
Adds # (feature)
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx