Added an Action for copying ATs while on NeoForge 1.21.4+#2537
Added an Action for copying ATs while on NeoForge 1.21.4+#2537Nyfaria wants to merge 14 commits intominecraft-dev:devfrom
Conversation
|
New PRs should target the |
|
Hi, please rebase your commit onto the dev branch |
i believe i have done that? i may be wrong. i've never rebased a pr before |
Earthcomputer
left a comment
Earthcomputer
left a comment
There was a problem hiding this comment.
You didn't rebase properly. I can merge manually if you can't figure out how to rebase, that's no problem.
| ideaVersionName = 2024.3 | ||
|
|
||
| coreVersion = 1.8.7 | ||
| coreVersion = 1.8.8 |
There was a problem hiding this comment.
Please don't bump the version in PRs
| import java.awt.Toolkit | ||
| import java.awt.datatransfer.StringSelection | ||
|
|
||
| class CopyNeoAtAction : AnAction() { |
There was a problem hiding this comment.
Does this need to be a separate action? Could you not just fix the existing AT action to work on 1.21.4+?
There was a problem hiding this comment.
ill reopen a new PR with it done better.
5 participants
Neoforge uses runtime mappings on 1.21.4+ so the copy AT fails to find a string.
In this PR i took the fabric AWs and just modified em to provide the proper AT for neoforge.