Skip to content

retain circle 导致timerLabel不能释放 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

retain circle 导致timerLabel不能释放 #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
549106e
retain circle 导致timerLabel不能释放
Jun 2, 2016
a3fc153
倒计时会少一秒
Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MZTimerLabel/MZTimerLabel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ typedef enum{
@property (nonatomic,copy) NSString *timeFormat;

/*Target label obejct, default self if you do not initWithLabel nor set*/
@property (nonatomic,strong) UILabel *timeLabel;
@property (nonatomic,weak) UILabel *timeLabel;

/*Used for replace text in range */
@property (nonatomic, assign) NSRange textRange;
Expand Down Expand Up @@ -110,6 +110,7 @@ typedef enum{
#endif
-(void)pause;
-(void)reset;
- (void)cleanTimerLabel;

/*--------Setter methods*/
-(void)setCountDownTime:(NSTimeInterval)time;
Expand Down
10 changes: 9 additions & 1 deletion MZTimerLabel/MZTimerLabel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,14 @@ - (id)initWithCoder:(NSCoder *)aDecoder

#pragma mark - Cleanup

- (void) removeFromSuperview {
- (void)cleanTimerLabel {
if (_timer) {
[_timer invalidate];
_timer = nil;
}
}

- (void)removeFromSuperview {
if (_timer) {
[_timer invalidate];
_timer = nil;
Expand All @@ -126,6 +133,7 @@ - (void)setCountDownTime:(NSTimeInterval)time{

timeUserValue = (time < 0)? 0 : time;
timeToCountOff = [date1970 dateByAddingTimeInterval:timeUserValue];
timeToCountOff = [timeToCountOff dateByAddingTimeInterval:0.99];
[self updateLabel];
}

Expand Down