power multiplication fix #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 16, 2024 16:01
… of the bug was that machines can be a part of multiple networks and generate power for each of the networks. This was fixed by checking if machine is already part of an other network and not making it a part of the current one. When network times out the network meta string value is cleared and the clear_networks function is used to try to connect the machine to a different network.
SmallJoker
reviewed
Nov 17, 2024
added 4 commits
November 17, 2024 17:04
…mproved clear_networks function fixed network not being cleared in some cases. Moved new network finding for machines to when network is cleared instead of on timeout.
SmallJoker
reviewed
Nov 21, 2024
Member
SmallJoker
left a comment
SmallJoker
left a comment
There was a problem hiding this comment.
Works well so far. Connected and disconnected a few cables. The machines are updated correctly.
…esarily checking technic.network[network_id] for nil, moved network_id nil checking inside clear_network function
SmallJoker
approved these changes
Nov 22, 2024
Member
SmallJoker
left a comment
SmallJoker
left a comment
There was a problem hiding this comment.
Thank you for the update.
Works. Will merge in a few days unless there are objections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed power multiplication bug. Resolves #277. The cause of the bug was that machines can be a part of multiple networks and generate power for each of the networks. This was fixed by checking if machine is already part of an other network and not making it a part of the current one. When network times out the network meta string value is cleared and the clear_networks function is used to try to connect the machine to a different network.