Skip to content

Fix: Add missing type annotations to serialization dataclass fields #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Fix: Add missing type annotations to serialization dataclass fields #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions minio/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ def toxml(self, element):
class CSVInputSerialization(InputSerialization):
"""CSV input serialization."""

allow_quoted_record_delimiter = None
comments = None
field_delimiter = None
file_header_info = None
quote_character = None
quote_escape_character = None
record_delimiter = None
allow_quoted_record_delimiter: Optional[str] = None
comments: Optional[str] = None
field_delimiter: Optional[str] = None
file_header_info: Optional[str] = None
quote_character: Optional[str] = None
quote_escape_character: Optional[str] = None
record_delimiter: Optional[str] = None

def __post_init__(self):
if (
Expand Down Expand Up @@ -128,7 +128,7 @@ def toxml(self, element):
class JSONInputSerialization(InputSerialization):
"""JSON input serialization."""

json_type = None
json_type: Optional[str] = None

def __post_init__(self):
if (
Expand Down Expand Up @@ -170,11 +170,11 @@ def toxml(self, element):
class CSVOutputSerialization(OutputSerialization):
"""CSV output serialization."""

field_delimiter = None
quote_character = None
quote_escape_character = None
quote_fields = None
record_delimiter = None
field_delimiter: Optional[str] = None
quote_character: Optional[str] = None
quote_escape_character: Optional[str] = None
quote_fields: Optional[str] = None
record_delimiter: Optional[str] = None

def __post_init__(self):
if (
Expand Down Expand Up @@ -211,7 +211,7 @@ def toxml(self, element):
class JSONOutputSerialization(OutputSerialization):
"""JSON output serialization."""

record_delimiter = None
record_delimiter: Optional[str] = None

def toxml(self, element):
"""Convert to XML."""
Expand Down
Loading