build: Update minio-java build for JUnit 5 support #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minio-java install script to support JUnit 5, which is required by minio-java >= 8.6.0 (commit 044c33c481c67d7061b1f99ed0ea39fc06ac306b). Changes: - Update SPOTBUGS_VERSION from 4.2.2 to 4.8.6 (as per minio-java upgrade) - Replace JUnit 4 (4.12) with JUnit 5 (5.11.3) - Download JUnit 5 dependencies: - junit-jupiter-api: Test annotations (@test, @beforeeach, etc.) - junit-jupiter-engine: Test execution engine - junit-platform-commons: Platform utilities - junit-platform-engine: Test engine API - apiguardian-api: API version annotations - opentest4j: Test failure exceptions This matches the dependencies used in minio-java's build.gradle and allows Mint to compile and run tests with current minio-java versions. Removed the conditional JUnit 4/5 logic since Mint always fetches the latest minio-java version from Maven, which will always be >= 8.6.0. Signed-off-by: Kefu Chai <[email protected]>
Member
|
Currently working on a bigger upgrade, so most likely this will be covered there already. cc @harshavardhana |
Author
|
@rraulinio hi Raul, thanks for the info. probably we can keep this pull request open until the bigger upgrade lands? so it can help other developers who try to build and use mint from the source instead of from the prebuilt container image? |
Author
|
superseded by #399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minio-java install script to support JUnit 5, which is required by minio-java >= 8.6.0 (commit 044c33c481c67d7061b1f99ed0ea39fc06ac306b).
Changes:
This matches the dependencies used in minio-java's build.gradle and allows Mint to compile and run tests with current minio-java versions.
Removed the conditional JUnit 4/5 logic since Mint always fetches the latest minio-java version from Maven, which will always be >= 8.6.0.