Skip to content

Simplify safe_chars construction #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify safe_chars construction #81

wants to merge 1 commit into from

Conversation

@rgrinberg
Copy link
Member

  • Move the safe chars type into its own module
  • Add add_{safe,unsafe} functions to make it easy to manipulate

@rgrinberg
Simplify safe_chars construction
006d01f 
* Move the safe chars type into its own module
* Add add_{safe,unsafe} functions to make it easy to manipulate
@rgrinberg
Copy link
Member Author

False alarm on travis

@rgrinberg
Copy link
Member Author

@dsheets What about this change? Seems like a decent simplification.

@lindig
Copy link

lindig commented Jul 10, 2024

If this is about performance, why not use a bit vector of 256 bits (32 char string or 4 int64 array) to encode safe and unsafe characters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgrinberg @lindig