Followup for "Allow perl wrapper to use language-Country values" PR #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TMDB API, there are some requests which want or need `language` parameter to be an ISO 639-1 (Aplha-2) language code (and not a language-Country). In these requests, we use now the first part of the language parameter, in order to have the needed ISO 639-1 (Aplha-2) language code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating PR #15, I've discovered that a small subset of the TMDB API requests still need or request an ISO 639-1 (Aplha-2) language code value for the
languageparameter.Examples of that are
Movie::imagesandTV::images.So, for those few requests, I now use just the 1st part of the
Session::langvalue, in order to give the TMDB API, the ISO 639-1 (Aplha-2) language code value they ask.