Fix accessibility issues in SGA

[amir-qayyum-khan]

In this PR I fixed accessibility related issues. Added necessary ARIA tags into code.

@carsongee and @pdpinch please review it

Thanks

[pdpinch]

@amir-qayyum-arbisoft it looks like this needs a rebase?

FYI, @bdero is going to put this on sandbox and we'll see if we can get it reviewed by an MIT accessibility specialist.

[bdero]

This is on sandxox2o

[bdero]

A loop would probably be overkill for this, but please store the element before making these calls:

var uploadElement =  $(content).find(".upload");
uploadElement.attr(/* params */)
// ...etc...

[amir-qayyum-khan]

@pdpinch and @bdero done with fix

[pdpinch]

@amir-qayyum-khan are there any changes we should consider for this, based on what you heard from edX?

[tssheth]

How might I test this?

[amir-qayyum-khan]

@jetej You can use screen reading tools like chromeVox (A chrome browser plugin) or command+F5 on mac to verify this PR.
Also read http://edx-partner-course-staff.readthedocs.org/en/latest/getting_started/accessibility.html

[tssheth]

Seems to work ok. I was able to use VoiceOver with both the student and instructor UI.

[pdpinch]

We'll still need another round of accessibility review after this, but this seems worth merging.

[pdpinch]

typo: should these be "upload_label"

[pdpinch]

Let's merge after the typo fix. This will all need another round of accessibility review afterwards, but this is an improvement.

[amir-qayyum-khan]

@pdpinch issue fixed

[pdpinch]

should this be tabindex="-1" ?

[tssheth]

tabindex="-1"

[amir-qayyum-khan]

Done @pdpinch

• There are one more things that needs to be add in dialogs:

  Add close icons in each dialog
  Trap focus in each dialog

• File uploading accessibility is fixed in Made file uploading for student some like staff annotated file upload and added focus to error message #106

[pdpinch]

@amir-qayyum-khan not urgent, but could you rebase this sometime? I'm not sure if it's still relevant, but I'd like to clean this up.

[pdpinch]

@amir-qayyum-khan do you know if we have an issue for this?

[amir-qayyum-khan]

I dont think so @pdpinch

[pdpinch]

@amir-qayyum-khan can you address the merge conflicts?