separate login and signup redirects #2384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/signup-redirect
branch
from
f6eb3d5 to
208c9bb
Compare
ChristopherChudzicki
added
the
Needs Review
rhysyngsun
requested changes
Jul 30, 2025
Comment on lines
+88
to
+89
| else: | ||
| return redirect(signup_redirect_url) |
There was a problem hiding this comment.
It's possible that signup_next isn't specified and I think it's reasonable to have this implemented so that it's not required. In that case, it should fall back to next, otherwise the default (/app).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/7734
Description (What does it do?)
This PR adds separate redirect parameters for login and signup. Our login URLs are now of the form:
How can this be tested?
Locally, with keycloak enabled, check that: