Fix Provide More Info dialog to save to profile #2983
Conversation
annagav
changed the title
annagav
changed the title
|
Why are first name and last name required fields? |
|
The First and Last name are required fields in filling out the profile. I don't know why. |
|
See https://github.com/mitodl/hq/issues/8492#issuecomment-3353753166, explicit code was added to always reject blank names |
|
If we want to allow First and Last name to be blank why are they required fields in the profile form? |
| htmlFor="legal_address.last_name" | ||
| isRequired={true} | ||
| label="Last Name" | ||
| subLabel="Name that will appear on emails" |
There was a problem hiding this comment.
I don't think this subLabel is correct. Can we just omit it, like we do on https://mitxonline.mit.edu/create-profile/
|
We need to make sure that adding this doesn't interrupt the UAI "one-click enrollment" flow. That said, we will probably need to add firstname and lastname to the Learn dashboard UI, in addition to the existing support for country and age. |
3 participants
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/8492
Description (What does it do?)
adds all required fields (that are currently blank) to the dialog requesting to fill out missing fields.
Screenshots (if appropriate):
How can this be tested?
Create a user account
make sure not to fillout the "create-profile" form
enroll yourself in a current course
click go to Course
fillout the missing fields
NOTE: it should only ask for missing required fields
Go to profile and verify that the fields got saved into the profile.