Skip to content

Conversation

d3vco
Copy link
Contributor

@d3vco d3vco commented Sep 22, 2025

Description

Fixes #3206 by reducing the try/except boundary.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Local startup test.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@deacon-mp deacon-mp requested a review from Copilot September 29, 2025 23:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a data loading issue by refining exception handling boundaries. Instead of having a single try/except block around the entire loading process, exceptions are now caught at more granular levels to prevent one plugin's failure from stopping the entire loading process.

  • Moved exception handling from method-level to individual plugin and task processing
  • Added more granular error handling for plugin loading and async task execution
  • Maintained existing debug logging for exceptions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +307 to 311
await self._load_extensions()
await self._load_data_encoders(plugins)
await self.create_or_update_everything_adversary()
await self._verify_data_sets()

Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These critical operations at the end of the method are no longer wrapped in exception handling. If any of these methods fail, they will cause the entire _load method to fail and potentially crash the application. Consider adding try/except blocks around these operations or ensure they have their own internal error handling.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Loading Failure
1 participant