Optimized complexity of the MemoryStream write operation. #116
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexity of the MemoryStream write operation was O(n) now it is O(log(n)). Complexity gets amortized to O(1) in case of large number of write operations. This change solves issue that occurs when the user has 100MB environment map, which causes Mitsuba renderer to serialize the environment in 20 minutes. Slowdown occurs when user tries to render the scene with the large environment map using distributed rendering with multiple machines in the network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized complexity of the MemoryStream write operation. Before complexity of the MemoryStream write operation was O(n) now it is
O(log(n)). Complexity gets amortized to O(1) in case of large number of write
operations.
This change solves issue that occurs when the user has 100MB environment map,
which causes Mitsuba renderer to serialize the environment in 20 minutes. Slowdown
occurs when user tries to render the scene with the large environment map using
distributed rendering with multiple machines in the network.