contrib(nvidia): match right apt repo based on os release #5913
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Apr 15, 2025
contrib/cdisetup/nvidia/nvidia.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if osid != "debian" && osid != "ubuntu" { |
There was a problem hiding this comment.
Looking at https://developer.download.nvidia.com/compute/cuda/repos/ we could have support for other distribs in the future.
crazy-max
force-pushed
the
nvidia-contrib-match-repo
branch
from
64f37c8 to
6390586
Compare
crazy-max
changed the title
tonistiigi
reviewed
Apr 15, 2025
Yes I was looking to move buildkit to debian base distro and I thought it would be better to use the right apt repo. |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
nvidia-contrib-match-repo
branch
from
6390586 to
6d49cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And keep fallback to
ubuntu2404for ubuntu distrib anddebian12for debian. Fallback can happen for releases still in testing/sid.