-
Notifications
You must be signed in to change notification settings - Fork 1.3k
use ubuntu base for buildkit image #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR switches the default base image for Buildkit to Debian and differentiates between Debian and Alpine variants.
- Updated the workflow matrix to include a new "base" key with values for Debian (empty string) and Alpine.
- Adjusted environment variable configurations accordingly to use the new matrix keys.
Files not reviewed (3)
- Dockerfile: Language not supported
- docker-bake.hcl: Language not supported
- hack/images: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/buildkit.yml:191
- [nitpick] The matrix key 'base' may not clearly indicate that an empty string represents Debian. Consider using a more descriptive name such as 'imageBase' to clarify intent.
+ base:
.github/workflows/buildkit.yml:192
- [nitpick] It might be helpful to add a comment explaining that an empty string for 'base' indicates the default Debian image, improving maintainability.
+ - ''
5d94f62
to
80285f9
Compare
Ubuntu rootless doesn't build with uid 1000 as it already exists. Wonder if we should change it for both Alpine and Ubuntu to be consistent 🤔 https://github.com/moby/buildkit/actions/runs/16194070978/job/45717191384?pr=5944#step:7:1930
Edit: Skipped user creation and use one already created from base image. |
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
This sets ubuntu as default base for the buildkit image. This will allow us to setup CDI within the container for NVIDIA devices that require glibc for client librairies.
Last commits publish both alpine and ubuntu variants using the following format:
moby/buildkit:<tag>
: ubuntu rootmoby/buildkit:<tag>-ubuntu
: ubuntu rootmoby/buildkit:<tag>-ubuntu-nvidia
: ubuntu root with nvidia contrib tagmoby/buildkit:<tag>-rootless
: ubuntu rootlessmoby/buildkit:<tag>-rootless-ubuntu
: ubuntu rootlessmoby/buildkit:<tag>-alpine
: alpine rootmoby/buildkit:<tag>-rootless-alpine
: alpine rootless