dockerfile: fix created time taken from base image if named context used #6096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created time for returned image config should be nil, and gets reset to the timestamp of last layer created during build in the exporter. This was the case when using base images from registry but was not the case when base image was replaced with the named context. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
Jul 18, 2025
| @@ -484,8 +484,7 @@ func toDispatchState(ctx context.Context, dt []byte, opt ConvertOpt) (*dispatchS | |||
| d.dispatched = true | |||
| d.state = *st | |||
| if img != nil { | |||
| // timestamps are inherited as-is, regardless to SOURCE_DATE_EPOCH | |||
| // https://github.com/moby/buildkit/issues/4614 | |||
| img.Created = nil | |||
There was a problem hiding this comment.
@AkihiroSuda This comment was from #4663 . Iiuc created time needs to be only maintained for d.baseImg .
|
Fixes #6098 |
crazy-max
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6098
Created time for returned image config should be nil, and gets reset to the timestamp of last layer created during build in the exporter.
This was the case when using base images from registry but was not the case when base image was replaced with the named context.