Skip to content

dfgitutil: don't initialize ref from checksum #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

dfgitutil: don't initialize ref from checksum #6176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions frontend/dockerfile/dfgitutil/git_ref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,5 @@ func (gf *GitRef) loadQuery(query url.Values) error {
}
gf.Ref = branch
}
if gf.Checksum != "" && gf.Ref == "" {
gf.Ref = gf.Checksum
}
return nil
}
15 changes: 15 additions & 0 deletions frontend/dockerfile/dockerfile_addgit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,26 @@ COPY foo out
url: serverURL + "/.git?commit=" + commitHashV2,
expectOut: "v0.0.2\n",
},
{
name: "v2 by commit (wrong short)",
url: serverURL + "/.git?commit=" + commitHashV2[:8],
expectErr: "expected checksum to match",
},
{
name: "v2 by commit (short)",
url: serverURL + "/.git?commit=" + commitHashLatest[:8],
expectOut: "latest\n",
},
{
name: "v2 ref by commit",
url: serverURL + "/.git?ref=" + commitHashV2,
expectOut: "v0.0.2\n",
},
{
name: "v2 ref by commit (short)",
url: serverURL + "/.git?ref=" + commitHashV2[:8],
expectErr: "repository does not contain ref",
},
{
name: "tag with commit",
url: serverURL + "/.git?tag=v0.0.2&commit=" + commitHashV2,
Expand Down