Enhance tests covering various facets of stubbing, this is groundwork towards implementing improved suspend function support #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C of 1.9.0 to a released version 1.10.2
…ngStubbingTest to new class StubbingTest
…suspend functions of this test interface to a new interface SuspendFunctions
…' assertion inspired by a similar assertion in JUnit5. The new assertion function asserts an exception of the given type is thrown by the block lambda and the exception is returned for further assertions.
This was referenced Nov 29, 2025
m-koops
changed the title
TimvdLippe
approved these changes
Nov 30, 2025
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Reviewing per commit was crucial to understand all the moving pieces. Thank you for taking your time doing so and all the test suite improvements. Given that no main source code is changed and only tests were updated, I trust the process that these changes are fine.
Given that all commits themselves also pass (nice!), I will rebase and merge to preserve the well-curated history. For PRs that touch main source code, I want to squash these, so make sure they are smaller than this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #553, that PR had become very large and hard to review, due to its many changes all combined in 1 squashed commit. This PR is a first step to break down that big PR and deliver a train of smaller PRs that ultimately lead to a combined result comparable with #553. PR #553 is a proper reference to describe the context and aim of the changes, but in the end I expect #553 not to be merged as it will get superceeded by the train of smaller PRs.
This PR is taking all enhancements to the test code that can be done without touching any class of the current mainline code.
The commits in this PR are not (yet) squashed, as each of the commits represent a logic step in the evolution of the test code. Each commit is a valid and complete stage in the code history, as each commit has a proper commit message and a succesfull Gradle build.
I would advice to review the PR commit by commit, as each commit on its own is small and should be well comprehensible.
Merging this PR would set the stage to introduce the enhancements to the mainline code that I will present in smaller and more manageable PRs as well.