mcp: add resource subscriptions #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements resource subscriptions for the MCP (Model Context Protocol), allowing clients to subscribe to and receive notifications when specific resources change. The implementation follows the MCP specification for resource subscriptions.
Key changes:
- Added server-side subscription management with handlers for subscribe/unsubscribe operations
- Implemented client-side subscription methods and notification handling
- Added comprehensive test coverage for the subscription workflow
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mcp/protocol.go | Defines subscription-related protocol structures (SubscribeParams, UnsubscribeParams, ResourceUpdatedNotificationParams) |
| mcp/server.go | Implements server-side subscription tracking, handlers, and notification routing |
| mcp/client.go | Adds client-side subscription methods and notification handler registration |
| mcp/server_test.go | Tests server capability reporting for resource subscriptions |
| mcp/mcp_test.go | End-to-end integration tests for the complete subscription workflow |
| design/design.md | Documentation updates explaining subscription usage patterns |
RoyceLeonD
reviewed
Jul 18, 2025
samthanawalla
force-pushed
the
resourcesubs
branch
from
7b5ea37 to
4d65676
Compare
jba
requested changes
Jul 22, 2025
jba
requested changes
Jul 22, 2025
mcp/server.go
Outdated
| } | ||
| var sessions []*ServerSession | ||
| for _, session := range s.sessions { | ||
| if _, ok := subscribedSessionIDs[session.ID()]; ok { |
There was a problem hiding this comment.
It's a bool map, so just if m[k]
There was a problem hiding this comment.
Changed to map[*ServerSession]bool
This CL adds the ability for clients to subscribe and receive updates for resources as described in https://modelcontextprotocol.io/specification/2025-06-18/server/resources#subscriptions
Co-authored-by: Copilot <[email protected]>
samthanawalla
force-pushed
the
resourcesubs
branch
from
1a96f92 to
14c9442
Compare
jba
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds the ability for clients to subscribe and receive updates for resources as described in https://modelcontextprotocol.io/specification/2025-06-18/server/resources#subscriptions
Fixes: #23