auth: clone the client request body before roundtripping #597
+83
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findleyr
force-pushed
the
oauth
branch
6 times, most recently
from
a1fbc37 to
d412e55
Compare
|
Staticcheck failures are being addressed in #599. |
jba
requested changes
Oct 22, 2025
RoundTrippers may read and close the body, so be careful to clone before roundtripping during client oauth, as the request may be issued multiple times. Fixes modelcontextprotocol#590
findleyr
commented
Oct 22, 2025
findleyr
commented
Oct 22, 2025
auth/client_test.go
Outdated
| client := &http.Client{Transport: transport} | ||
|
|
||
| resp, err := client.Post(authServer.URL, "application/json", &basicReader{strings.NewReader("{}")}) | ||
| // resp, err := client.Post(authServer.URL, "application/json", strings.NewReader("{}")) |
jba
previously approved these changes
Oct 22, 2025
jba
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoundTrippers may read and close the body, so be careful to clone before roundtripping during client oauth, as the request may be issued multiple times.
Fixes #590