Skip to content

fix: correct stdout buffering issues in spawned processes #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2025
+8 −0
Merged

fix: correct stdout buffering issues in spawned processes #739

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e47d7d
fix: correct stdout buffering issues in spawned processes
nsheaps Aug 21, 2025
d758e8b
Merge branch 'main' into main
nsheaps Aug 22, 2025
1f197bf
Merge branch 'main' into main
nsheaps Aug 26, 2025
80ab4dc
Merge branch 'main' into main
olaservo Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cli/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ async function runWebClient(args: Args): Promise<void> {
await spawnPromise("node", [inspectorClientPath, ...startArgs], {
signal: abort.signal,
echoOutput: true,
// pipe the stdout through here, prevents issues with buffering and
// dropping the end of console.out after 8192 chars due to node
// closing the stdout pipe before the output has finished flushing
stdio: "inherit",
});
} catch (e) {
if (!cancelled || process.env.DEBUG) throw e;
Expand Down Expand Up @@ -151,6 +155,10 @@ async function runCli(args: Args): Promise<void> {
env: { ...process.env, ...args.envArgs },
signal: abort.signal,
echoOutput: true,
// pipe the stdout through here, prevents issues with buffering and
// dropping the end of console.out after 8192 chars due to node
// closing the stdout pipe before the output has finished flushing
stdio: "inherit",
});
} catch (e) {
if (!cancelled || process.env.DEBUG) {
Expand Down