Fix a typo in progress notification method name #745
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shoud be `notifications/progress` not `notification/progress` (not singular). This matches the latest spec. https://modelcontextprotocol.io/specification/2025-06-18/basic/utilities/progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shoud be
notifications/progressnotnotification/progress(not singular).This matches the latest spec.
https://modelcontextprotocol.io/specification/2025-06-18/basic/utilities/progress
Fixed a typo that displayed the method name as
notification/progress(singular) instead ofnotifications/progress(plural) in Server Notifications section.Motivation and Context
The typo led me to start looking to fastmcp python code as I thought that there was bug in fastmcp code.
How Has This Been Tested?
I verified it in the inspector UI.
Breaking Changes
It is a very minor change. Not a breaking change.
Types of changes
Checklist
Additional context
N/A