Skip to content

add ktlint and cleanup code #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add ktlint and cleanup code #194

wants to merge 1 commit into from

Conversation

devcrocod
Copy link
Contributor

#171

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@devcrocod devcrocod requested review from sdubov and tiginamaria July 25, 2025 12:38
@StefMa
Copy link
Contributor

StefMa commented Jul 25, 2025

You should also add this to a CI workflow...

@devcrocod
Copy link
Contributor Author

@StefMa
What do you mean?
ktlintCheck is triggered along with the build task, so the Validation PR will automatically run it.
Or did you mean we should also add ktlintFormat?

@StefMa
Copy link
Contributor

StefMa commented Jul 26, 2025

Ah okay 👌
Didn't know that it hook into the build task.

No, format should not run on CI 🙃

@devcrocod
Copy link
Contributor Author

Obsolete

@devcrocod devcrocod closed this Aug 4, 2025
@devcrocod devcrocod deleted the devcrocod/add-linter branch August 4, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants