Skip to content

Add CodeQL workflow for Kotlin analysis #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Add CodeQL workflow for Kotlin analysis #200

merged 2 commits into from
Jul 30, 2025

Conversation

devcrocod
Copy link
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to enable CodeQL static analysis for Kotlin code in the repository, providing automated security vulnerability scanning and code quality checks.

  • Adds a comprehensive CodeQL workflow configuration targeting Kotlin/Java analysis
  • Configures the workflow to run on pushes, pull requests to main, and weekly schedule
  • Sets up manual build mode with Gradle caching for efficient analysis
Comments suppressed due to low confidence (2)

.github/workflows/codeql.yml:41

  • The CodeQL action version @V3 is outdated. Consider upgrading to @v4 which includes performance improvements and bug fixes.
        uses: github/codeql-action/init@v3

.github/workflows/codeql.yml:60

  • The CodeQL action version @V3 is outdated. Consider upgrading to @v4 to match the init action and benefit from latest improvements.
        uses: github/codeql-action/analyze@v3

path: |
~/.gradle/caches
~/.gradle/wrapper
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
Copy link
Preview

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache configuration is missing a restore-keys fallback, which could result in cache misses when gradle files change slightly. Consider adding restore-keys to improve cache hit rates.

Suggested change
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-

Copilot uses AI. Check for mistakes.

@devcrocod devcrocod force-pushed the devcrocod/fix-codeql branch from ba43cfa to f9bca7b Compare July 29, 2025 10:02
@devcrocod devcrocod requested a review from e5l July 29, 2025 11:19
Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l e5l enabled auto-merge (squash) July 30, 2025 07:12
@e5l e5l disabled auto-merge July 30, 2025 07:12
@e5l e5l enabled auto-merge (squash) July 30, 2025 07:12
@e5l e5l merged commit 641df74 into main Jul 30, 2025
4 checks passed
@e5l e5l deleted the devcrocod/fix-codeql branch July 30, 2025 07:17
skarpovdev pushed a commit to skarpovdev/kotlin-sdk that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants