-
Notifications
You must be signed in to change notification settings - Fork 2.7k
test: update SSE tests to use StreamingASGITransport instead of uvicorn for server testing #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bjoaquinc
wants to merge
17
commits into
modelcontextprotocol:main
Choose a base branch
from
bjoaquinc:streaming-asgi-sse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: update SSE tests to use StreamingASGITransport instead of uvicorn for server testing #1566
bjoaquinc
wants to merge
17
commits into
modelcontextprotocol:main
from
bjoaquinc:streaming-asgi-sse
+188
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_context_propogation to apply this methodology
…nstead. DRY implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs more work
Not ready to be merged yet, needs additional changes.
P3
Nice to haves, rare edge cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements fixes to the
StreamingASGITransportto properly handle SSE streaming and disconnect signaling. The key changes were:receive()to fix SSE hangingSseServerTransportto eliminate ResourceWarningshttp.response.startgracefully during teardownI also modified one test in
tests/shared/test_sse.pyto validate this methodology. I'll be updating all tests after validation.Motivation and Context
Partially resolves #857
How Has This Been Tested?
Since I updated the testing methodology I made sure to run the test in batches of 20 (to check for race conditions). After the updates I was able to get it working for the modified test.
Breaking Changes
None.
StreamingASGITransportis only meant for testing. Also before this PR, it was not implemented anywhere in the codebase. The only change I made toSseServerTransportwas to properly clean upsse_stream_readerwhich is best practice and doesn't break functionality. The modifiedtest_request_context_propagationfunctions as expected.Types of changes
Checklist
Additional context