fix(oauth): do not treat empty secret as valid for public clients #443
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the oauth's client registration portion where we should treat empty client secret as invalid. The rationale is pretty much written in the code comment.
Motivation and Context
This will expand the support for more auth servers.
How Has This Been Tested?
This makes Goose work with some public IdP providers such as https://app.descope.com
Breaking Changes
N/A
Types of changes
Checklist
Additional context
The following is the example client registration response to the request made by Goose where the
client_secret
field is present vs its value is empty string.