-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrade to Node LTS #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node LTS #1072
Conversation
package.json
Outdated
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=18", | ||
| "npm": ">=10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the NPM upgrade intentional? Apparently node 18 ships with older npm versions, might be an inadvertently breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it shipped with 10+ but yep I'm wrong. Will remove:
{
"version": "v18.0.0",
"date": "2022-04-18",
"files": [
"aix-ppc64",
"headers",
"linux-arm64",
"linux-armv7l",
"linux-ppc64le",
"linux-s390x",
"linux-x64",
"osx-arm64-tar",
"osx-x64-pkg",
"osx-x64-tar",
"src",
"win-x64-7z",
"win-x64-exe",
"win-x64-msi",
"win-x64-zip"
],
"npm": "8.6.0",
"v8": "10.1.124.8",
"uv": "1.43.0",
"zlib": "1.2.11",
"openssl": "3.0.2+quic",
"modules": "108",
"lts": false,
"security": false
},
commit: |
felixweinberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updates node from 18 to current LTS (24) in Github CI as it is entering EOL in the new year.
Tests against both the oldest legacy version we should support until April (18) and current LTS (24).
I would strongly suggest we upgrade our oldest version to 22 soon.
Motivation and Context
How Has This Been Tested?
Tests test against both versions. We just build in the newer version so we can use tsdown. #1071
Breaking Changes
No
Types of changes
Checklist
Additional context