You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
mgyarmathy
changed the title
fix: Update UriTemplate implementation to handle optional/omitted, out-of-order, and encoded query parameters
[v2] fix: Update UriTemplate implementation to handle optional/omitted, out-of-order, and encoded query parameters
Jan 16, 2026
Thanks for the contribution! Closing in favor of #1785, which builds on your implementation with a small refinement: absent query parameters are omitted from the result rather than set to ''. This preserves round-trip fidelity with expand() and lets callers distinguish absent from empty. Your implementation approach (path/query split, Map-based parsing, URL decoding) is preserved and credited. Thanks again for the thorough fix across both branches!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several limitations of the current
UriTemplate#matchimplementation:Omitted query parameters are parsed as an empty string per guidance of RFC 6570 Section 2.3.
Motivation and Context
Fixes #1079
Fixes #149
How Has This Been Tested?
New test additions cover all of the cases mentioned in #1079 and #149 as well as a few additional potential edge cases I could come up with.
Breaking Changes
n/a
Types of changes
Checklist
Additional context