fix: throw error on auth fallback for non-root AS paths#1724
Open
guoyangzhen wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: throw error on auth fallback for non-root AS paths#1724guoyangzhen wants to merge 2 commits intomodelcontextprotocol:mainfrom
guoyangzhen wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Fixes modelcontextprotocol#1716 When authorization server metadata discovery fails and the server URL has a non-root path, the fallback to /authorize, /token, and /register endpoints silently constructs wrong URLs (losing the path prefix). This fix throws a descriptive error instead of silently redirecting to nonexistent endpoints. Affected locations: - startAuthorization: /authorize fallback - executeTokenRequest: /token fallback - registerClient: /register fallback
🦋 Changeset detectedLatest commit: ea8ea36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1716
When authorization server metadata discovery fails and the server URL has a non-root path (e.g.,
https://example.com/admin), the fallback to/authorize,/token, and/registerendpoints uses absolute paths that silently lose the URL path prefix.For example:
new URL('/authorize', 'https://example.com/admin')→https://example.com/authorize(wrong!)https://example.com/admin/authorizeProblem
Three locations in
packages/client/src/client/auth.tsconstruct fallback URLs using absolute paths:startAuthorization()line ~1204:new URL('/authorize', authorizationServerUrl)executeTokenRequest()line ~1286:new URL('/token', authorizationServerUrl)registerClient()line ~1533:new URL('/register', authorizationServerUrl)Per RFC 6749, the
/.well-knowndefaults only apply to authorization servers at the domain root. For non-root paths, metadata discovery is required.Fix
Added checks for non-root paths. When metadata discovery fails and the AS URL has a non-root pathname, a descriptive error is thrown instead of silently constructing a wrong URL.
Impact
n- Before: Silent redirect to wrong URL, broken auth flow with no diagnostic info