Skip to content

chore: update spec.types.ts from upstream#1888

Open
github-actions[bot] wants to merge 1 commit intomainfrom
update-spec-types
Open

chore: update spec.types.ts from upstream#1888
github-actions[bot] wants to merge 1 commit intomainfrom
update-spec-types

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR updates packages/core/src/types/spec.types.ts from the Model Context Protocol specification.

Source file: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/5c25208be86db5033f644a4e0d005e08f699ef3d/schema/draft/schema.ts

This is an automated update triggered by the nightly cron job.

@github-actions github-actions bot requested a review from a team as a code owner April 13, 2026 19:10
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: 617875d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — automated spec sync adding only JSDoc annotations, no type changes.

Extended reasoning...

Overview

This is the nightly automated sync of packages/core/src/types/spec.types.ts from the upstream MCP spec repo. The diff updates the source commit hash in the file header and adds two JSDoc annotations: @nullable on Task.ttl (which was already typed number | null) and @maxItems 100 on CompleteResult.completion.values (whose docstring already said "Must not exceed 100 items"). There are no changes to TypeScript types, exports, or runtime behavior.

Security risks

None. Comment-only changes in an auto-generated type definition file.

Level of scrutiny

Very low. This file is explicitly marked "DO NOT EDIT THIS FILE MANUALLY" and is regenerated by pnpm run fetch:spec-types via the nightly cron. The changes are purely documentation annotations that mirror constraints already expressed in the type signatures and prose. The spec.types.test.ts bidirectional assignability test would catch any actual type drift, and CI runs it.

Other factors

No changeset is included, which is appropriate since these JSDoc tags don't affect the published API surface or warrant a version bump on their own. No prior review comments to address.

@github-actions github-actions bot force-pushed the update-spec-types branch from 0260b1b to 617875d Compare April 14, 2026 04:56
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — automated spec sync, JSDoc-only annotations.

Extended reasoning...

Overview

Automated nightly sync of packages/core/src/types/spec.types.ts from the upstream spec repo. The diff consists of (1) bumping the source-commit hash in the file header, (2) adding a @nullable JSDoc tag to Task.ttl, and (3) adding a @maxItems 100 JSDoc tag to CompleteResult.completion.values. No TypeScript types, signatures, or exports change.

Security risks

None. Comment-only additions in a generated type-definitions file; no runtime code, no I/O, no auth surface.

Level of scrutiny

Very low. This file is explicitly auto-generated ("DO NOT EDIT THIS FILE MANUALLY"), the PR is produced by the nightly cron, and the changes are pure JSDoc annotations that mirror constraints already stated in the prose docstrings (null for unlimited, Must not exceed 100 items). Per the repo's spec-sync workflow (#1886, #1866), these PRs are routine and intended to be merged without ceremony.

Other factors

No changeset is needed since there is no observable API/behavior change. The bug-hunting system found nothing. spec.types.test.ts bidirectional checks are unaffected because no structural types changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants