Skip to content

feat(CellBudgetFile): support aux vars in get_ts() method #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wpbonelli
Copy link
Member

Add a variable parameter to the CellBudgetFile.get_ts() method defaulting to "q". Close #2270.

Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.4%. Comparing base (556c088) to head (37e3695).
⚠️ Report is 34 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/binaryfile/__init__.py 26.9% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2568      +/-   ##
===========================================
+ Coverage     55.5%    72.4%   +16.9%     
===========================================
  Files          644      667      +23     
  Lines       124135   128619    +4484     
===========================================
+ Hits         68947    93246   +24299     
+ Misses       55188    35373   -19815     
Files with missing lines Coverage Δ
flopy/utils/binaryfile/__init__.py 82.0% <26.9%> (-2.5%) ⬇️

... and 411 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review August 4, 2025 17:29
@wpbonelli wpbonelli requested a review from jlarsen-usgs August 4, 2025 17:29
@wpbonelli
Copy link
Member Author

@cneyens is this close to what you had in mind?

@cneyens
Copy link

cneyens commented Aug 7, 2025

@cneyens is this close to what you had in mind?

Yes, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: allow get_ts() to get auxiliary variables from the budget file
2 participants