-
Notifications
You must be signed in to change notification settings - Fork 342
feat(GeoDataFrame support): add in geopandas GeoDataFrame support #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jlarsen-usgs
wants to merge
13
commits into
modflowpy:develop
Choose a base branch
from
jlarsen-usgs:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayer file support
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2573 +/- ##
===========================================
+ Coverage 55.5% 71.8% +16.2%
===========================================
Files 644 643 -1
Lines 124135 122986 -1149
===========================================
+ Hits 68947 88341 +19394
+ Misses 55188 34645 -20543
🚀 New features to boost your workflow:
|
FWIW, I like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to begin overhauling the shapefile exporting support in FloPy. This PR adds geopandas GeoDataFrame constructors to data, package, model, and some output objects.
Todo:
Functionally the geopandas supports works as follows:
Input is requested on the
to_geo_dataframe()
method name. I keep going back and forth between that andto_geodataframe()
. Any preferences or other suggestions on naming convention?Other considerations and support suggestions are welcome