Skip to content

Conversation

jlarsen-usgs
Copy link
Contributor

@jlarsen-usgs jlarsen-usgs commented Aug 13, 2025

  • when True, the active_only flag creates an adjacency graph for metis that only includes active cells. Inactive cell membership is later assigned a model via nearest neighbor.
  • fix layer count for UnstructuredGrid splitting in optimize_splitting_mask and reconstruct_array
  • add options parameter to support pymetis.Options input

Closes #2576

* when True, the `active_only` flag creates an adjacency graph for metis that only includes active cells. Inactive cell membership is later assigned a model via nearest neighbor.
* fix layer count for UnstructuredGrid splitting in `optimize_splitting_mask` and `reconstruct_array`
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.2%. Comparing base (556c088) to head (cdda1c0).
⚠️ Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/utils/model_splitter.py 97.3% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2580      +/-   ##
===========================================
+ Coverage     55.5%    72.2%   +16.7%     
===========================================
  Files          644      643       -1     
  Lines       124135   122218    -1917     
===========================================
+ Hits         68947    88341   +19394     
+ Misses       55188    33877   -21311     
Files with missing lines Coverage Δ
flopy/discretization/grid.py 75.6% <ø> (-0.3%) ⬇️
flopy/mf6/utils/model_splitter.py 65.5% <97.3%> (-9.4%) ⬇️

... and 382 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mjr-deltares
Copy link
Contributor

Thx @jlarsen-usgs , we are going to test this PR on CONUS to see if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with optimize_splitting_mask() and reconstruct_array() for a split groundwater flow model with DISU grid
2 participants