Skip to content

Reworked app update flow #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Reworked app update flow #3960

wants to merge 31 commits into from

Conversation

Gaming32
Copy link
Collaborator

@Gaming32 Gaming32 commented Jul 10, 2025

The old app updater automatically installed new updates immediately on startup with no user involvement or consent. This reworks it to have a new modal that asks whether the user would like to update now, update on next restart, or skip this update.

Closes DEV-128

@Gaming32 Gaming32 added enhancement New feature or request app Relates to Modrinth App labels Jul 10, 2025
@Gaming32 Gaming32 marked this pull request as ready for review July 11, 2025 14:22
Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has more frontend than backend code, but both LGTM.

I just have a couple nitpicks I'd like to share below.

@Gaming32 Gaming32 requested a review from AlexTMjugador July 16, 2025 01:38
Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Prospector Prospector requested a review from IMB11 July 17, 2025 01:55
@Prospector
Copy link
Member

Prospector commented Jul 17, 2025

would be good to double check my latest changes didn't break functionality, requested another review from @IMB11

Feel free to queue for merge if it looks good to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants