-
Notifications
You must be signed in to change notification settings - Fork 299
Reworked app update flow #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reworked app update flow #3960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has more frontend than backend code, but both LGTM.
I just have a couple nitpicks I'd like to share below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
would be good to double check my latest changes didn't break functionality, requested another review from @IMB11 Feel free to queue for merge if it looks good to you |
The old app updater automatically installed new updates immediately on startup with no user involvement or consent. This reworks it to have a new modal that asks whether the user would like to update now, update on next restart, or skip this update.
Closes DEV-128