Skip to content

fix: handle identified files properly in the checklist #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 23, 2025
Merged

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented Jul 16, 2025

No description provided.

@IMB11 IMB11 added bug Something isn't working web Relates to Modrinth.com web frontend frontend labels Jul 16, 2025
@IMB11 IMB11 requested a review from jadelily18 July 16, 2025 17:45
@IMB11
Copy link
Member Author

IMB11 commented Jul 16, 2025

Needs testing with a project which has an identified permanent-no file.

@IMB11 IMB11 requested review from Prospector and coolbot100s and removed request for Prospector July 17, 2025 11:59
Copy link
Member

@jadelily18 jadelily18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces a bug where the "Copyrighted Content" message isn't generated the first time you click "Generate message", meaning you have to first generate the message, go back by clicking "Edit" and generate the message again.

Additionally, it would be really nice if unidentified files were listed before identified files, as they were before, since those require more manual input.

@IMB11 IMB11 requested review from jadelily18 and Minenash July 22, 2025 21:18
Copy link
Collaborator

@coolbot100s coolbot100s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a Modpack Permissions stage ends in "all permissions obtained" the step is uncompletable, causing a "Modpack permissions stage unfinished" error.

@IMB11 IMB11 requested a review from coolbot100s July 23, 2025 08:14
Copy link
Collaborator

@coolbot100s coolbot100s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workin' again!

@coolbot100s coolbot100s dismissed jadelily18’s stale review July 23, 2025 08:33

Issues addressed.

@IMB11 IMB11 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 15892a8 Jul 23, 2025
4 checks passed
IMB11 added a commit that referenced this pull request Jul 25, 2025
* fix: handle identified files from the backend

* fix: allFiles not being emitted after permissions flow completed

* fix: properly handle identified projects

* fix: jade issues

* fix: import

* fix: issue with perm gen msgs

* fix: incomplete error
@IMB11 IMB11 deleted the cal/checklist-fixes branch July 30, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend web Relates to Modrinth.com web frontend
Development

Successfully merging this pull request may close these issues.

3 participants