-
Notifications
You must be signed in to change notification settings - Fork 322
fix: handle identified files properly in the checklist #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needs testing with a project which has an identified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduces a bug where the "Copyrighted Content" message isn't generated the first time you click "Generate message", meaning you have to first generate the message, go back by clicking "Edit" and generate the message again.
Additionally, it would be really nice if unidentified files were listed before identified files, as they were before, since those require more manual input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a Modpack Permissions stage ends in "all permissions obtained" the step is uncompletable, causing a "Modpack permissions stage unfinished" error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workin' again!
* fix: handle identified files from the backend * fix: allFiles not being emitted after permissions flow completed * fix: properly handle identified projects * fix: jade issues * fix: import * fix: issue with perm gen msgs * fix: incomplete error
No description provided.